Skip to content

Don't restrict symfony/symfony packages #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2019
Merged

Don't restrict symfony/symfony packages #18

merged 1 commit into from
Jan 12, 2019

Conversation

nicolas-grekas
Copy link
Contributor

Will allow "unpack" to replace the wildcard by what's in extra.symfony.require also.
See symfony/flex#443
This should be the best practice.

Will allow "unpack" to replace the wildcard by what's in extra.symfony.require also.
See symfony/flex#443
This should be the best practice.
@teohhanhui
Copy link

teohhanhui commented Dec 11, 2018

I honestly do not understand why the * version constraint is a "best practice". And we don't have extra.symfony.require set here.

@nicolas-grekas
Copy link
Contributor Author

nicolas-grekas commented Dec 11, 2018

Because that's a pack - and packs should not impose constraints on your deps.

@nicolas-grekas
Copy link
Contributor Author

we don't have extra.symfony.require set here.

it's not "here", but in a flex-enabled app - which packs are built for.

@teohhanhui
Copy link

I still disagree. The extra.symfony.require in the app could be anything, and we cannot guarantee that things would actually work if we do not enforce our version constraints. (Of course, if the user does not use this pack, they might still install incompatible versions of the these optional dependencies.) These are the supported versions of Symfony components that we run our CI builds with.

@teohhanhui
Copy link

I think symfony/flex#443 is brilliant, but it still does not sufficiently address the concern I've raised before. This PR made me realize that.

@nicolas-grekas
Copy link
Contributor Author

nicolas-grekas commented Dec 11, 2018

That's not the responsibility of a pack (guarantee that things would actually work).

@teohhanhui
Copy link

teohhanhui commented Dec 11, 2018

This is how I think about it: a collection of dependencies that we've put together. And to me that also means the dependencies are in selected versions that work together.

But I see your point. (Especially because the type is symfony-pack, so I'd respect the semantics you've defined.)

@dunglas dunglas merged commit 9e3e742 into api-platform:master Jan 12, 2019
@dunglas
Copy link
Member

dunglas commented Jan 12, 2019

Thanks @nicolas-grekas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants