Merge pull request #2273 from antograssiot/phpstan-level6-master

Bump PHPStan analysis to level 6

Author: soyuka

phpstan.neon

@@ -28,7 +28,6 @@ parameters:
         # https://github.com/doctrine/doctrine2/pull/7298/files
         - '#Strict comparison using === between null and int will always evaluate to false\.#'
         - '#Strict comparison using !== between null and null will always evaluate to false\.#'
-        - '#Class ApiPlatform\\Core\\Tests\\Fixtures\\TestBundle\\Entity\\DummyBis not found.#'
         - '#Method ApiPlatform\\Core\\(Serializer\\Abstract|JsonApi\\Serializer\\)ItemNormalizer::normalizeRelation\(\) should return array\|string but returns array\|bool\|float\|int\|string\.#'
 
         # Expected, due to deprecations

src/Serializer/AbstractItemNormalizer.php

@@ -168,7 +168,7 @@ protected function instantiateObject(array &$data, $class, array &$context, \Ref
                 $paramName = $constructorParameter->name;
                 $key = $this->nameConverter ? $this->nameConverter->normalize($paramName) : $paramName;
 
-                $allowed = false === $allowedAttributes || \in_array($paramName, $allowedAttributes, true);
+                $allowed = false === $allowedAttributes || (\is_array($allowedAttributes) && \in_array($paramName, $allowedAttributes, true));
                 $ignored = !$this->isAllowedAttribute($class, $paramName, $format, $context);
                 if ($constructorParameter->isVariadic()) {
                     if ($allowed && !$ignored && (isset($data[$key]) || array_key_exists($key, $data))) {

tests/EventListener/RespondListenerTest.php

@@ -141,6 +141,8 @@ public function testSetSunsetHeader()
         $listener->onKernelView($event);
 
         $response = $event->getResponse();
-        $this->assertEquals(new \DateTimeImmutable('tomorrow'), \DateTime::createFromFormat(DATE_RFC1123, $response->headers->get('Sunset')));
+        /** @var string $value */
+        $value = $response->headers->get('Sunset');
+        $this->assertEquals(new \DateTimeImmutable('tomorrow'), \DateTime::createFromFormat(DATE_RFC1123, $value));
     }
 }

tests/Metadata/Extractor/ExtractorTestCase.php

@@ -175,7 +175,7 @@ final public function testResourcesParamatersResolution()
                 'attributes' => null,
                 'properties' => null,
             ],
-            \ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\DummyBis::class => [
+            '\ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\DummyBis' => [
                 'shortName' => null,
                 'description' => null,
                 'iri' => null,
@@ -301,7 +301,7 @@ final public function testResourcesParamatersResolutionWithTheSymfonyContainer()
                 'attributes' => null,
                 'properties' => null,
             ],
-            \ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\DummyBis::class => [
+            '\ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\DummyBis' => [
                 'shortName' => null,
                 'description' => null,
                 'iri' => null,