Skip to content

Bump PHPStan analysis to level 6 #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

antograssiot
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

This PR will allow to bump PHPStan level on master too once #2272 will be merged.

@dunglas
Copy link
Member

dunglas commented Oct 30, 2018

Can you rebase please @antograssiot?

@antograssiot antograssiot force-pushed the phpstan-level6-master branch from 859b8cc to 7dd3ccd Compare October 30, 2018 18:02
@antograssiot
Copy link
Contributor Author

rebased @dunglas, it should be all green soon hopefully

@soyuka soyuka merged commit 549214a into api-platform:master Oct 31, 2018
@soyuka
Copy link
Member

soyuka commented Oct 31, 2018

tyvm @antograssiot !

@antograssiot antograssiot deleted the phpstan-level6-master branch October 31, 2018 07:37
@antograssiot
Copy link
Contributor Author

My pleasure. Thanks for reviewing and merging my PRs (globaly I mean, not only this one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants