Skip to content

Fix the generated XML Schema type for float #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2017

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Mar 27, 2017

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

xmls:number doesn't even exist...

@dunglas dunglas merged commit 3d71261 into api-platform:2.0 Mar 28, 2017
@dunglas dunglas deleted the fix_xs_decimal branch March 28, 2017 10:17
@teohhanhui
Copy link
Contributor

Can we stick to the usually used prefix:

"xsd": "http://www.w3.org/2001/XMLSchema#"

instead of xmls

@dunglas
Copy link
Member Author

dunglas commented Mar 28, 2017

It would be a BC break...

@teohhanhui
Copy link
Contributor

Why would it be a BC break? If a client uses string matching to identify type, that's doing it wrong in the first place. Changing the prefix should not break anything. (Okay, I'm not sure about this edge case, but: unless someone added in their own xsd prefix too?)

@dunglas
Copy link
Member Author

dunglas commented Mar 28, 2017

Most parsers don't expand the JSON-LD and just do something like:

fetch('/docs.jsonld').then(response => reponse.json()).then(json => console.log(json['my:key']));

Such parsers will fail.

@teohhanhui
Copy link
Contributor

teohhanhui commented Mar 28, 2017

Non-standards compliant parsing... If that's considered a BC break, then we're in trouble. 😞

I mean, if one decides to do parsing like that, he/she should certainly understand the risks.

@dunglas
Copy link
Member Author

dunglas commented Mar 28, 2017

We may not be strict about this, however this change has no real benefits but can break things.

@teohhanhui
Copy link
Contributor

Okay, let's keep it for when we can actually break things again.

hoangnd25 pushed a commit to hoangnd25/core that referenced this pull request Feb 23, 2018
Fix the generated XML Schema type for float
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants