Upgrade Swagger UI to v3 (React inside) #1138
Conversation
dunglas
force-pushed
the
upgrade_swaggerui
branch
from
3c98315 to
c47a93d
Compare
|
Those diffs :/. Reminds me of #768. |
|
Yes but the new version improve things, we delete all previous files and there is only 2 JS files now. |
|
Oh yeah that's nice, I didn't saw that on first look. We may be able to reduce those to 1 file in the |
| <script src="{{ asset('bundles/apiplatform/swagger-ui/lib/marked.js') }}"></script> | ||
| <script src="{{ asset('bundles/apiplatform/swagger-ui/lib/swagger-oauth.js') }}"></script> | ||
| <script src="{{ asset('bundles/apiplatform/init-swagger-ui.js') }}"></script> | ||
| <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Open+Sans:400,700|Source+Code+Pro:300,600|Titillium+Web:400,600,700"> |
There was a problem hiding this comment.
I think we should import it... we shouln't need internet to load the Ui
There was a problem hiding this comment.
It'd still work when offline, the fallback font would just be used.
dunglas
force-pushed
the
upgrade_swaggerui
branch
from
c47a93d to
8528ad3
Compare
dunglas
force-pushed
the
upgrade_swaggerui
branch
from
8528ad3 to
5684bae
Compare
|
Why are we digging ourselves a new hole? As I've mentioned in #1149 (comment) and #1149 (comment), I believe this should live in a separate project. |
|
Well, I'm not against splitting this piece of code in another project later. But for 2.1 it will stay in core. |
|
Btw this PR removes ~ 12k lines of JS and CSS, we're on the good path isn't it? |
Uh oh!
There was an error while loading. Please reload this page.