Fix the Varnish purger #1156
Merged
Fix the Varnish purger #1156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
soyuka
reviewed
Jun 2, 2017
| @@ -48,10 +48,10 @@ public function purge(array $iris) | |||
| return sprintf('(^|\,)%s($|\,)', preg_quote($iri)); | |||
| }, $iris); | |||
|
|
|||
| $regex = isset($parts[1]) ? sprintf('(%s)', implode(')|(', $parts)) : $parts[0]; | |||
| $regex = count($parts) > 1 ? sprintf('(%s)', implode(')|(', $parts)) : array_shift($parts); | |||
There was a problem hiding this comment.
isset may still work with array shift no?
There was a problem hiding this comment.
No because the array has the following format: ['/foo' => '/foo', '/bar' => '/bar']
There was a problem hiding this comment.
:| nice way to avoid counting otherwise.
There was a problem hiding this comment.
current might work, not sure about the perf reward though. array_shift does put cursor in position 0 every call.
There was a problem hiding this comment.
Perf are better with current() (or array_pop() for example). But I prefer reset(), it's more safe.
soyuka
approved these changes
Jun 2, 2017
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
Fix the Varnish purger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestinstead ofrequestAsyncto throw an error in the purge doesn't work