Avoid serializing "resources" in the normalization context #1307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
reviewed
Aug 4, 2017
| @@ -60,7 +60,9 @@ public function onKernelView(GetResponseForControllerResultEvent $event) | |||
|
|
|||
| $context = $this->serializerContextBuilder->createFromRequest($request, true, $attributes); | |||
| $resources = []; | |||
| $context['resources'] = &$resources; | |||
| $context['resources'] = function ($iri) use (&$resources) { | |||
There was a problem hiding this comment.
Do you have the same output has before ? if yes then it seems ok to me.
There was a problem hiding this comment.
Yes but it's fucked up that a Closure is faster then a reference in this case. There may be a simple explanation with the internal memory pointer doing less work, I would love to understand :p.
There was a problem hiding this comment.
Did you try to compare the opcode ?
soyuka
changed the title
meyerbaptiste
approved these changes
Aug 4, 2017
Simperfit
approved these changes
Aug 4, 2017
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
Avoid serializing "resources" in the normalization context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because getCacheKey serializes the
context, let's avoid serializing the$context['resources']that can get pretty big.Solves the performance issue.