Issues/1246 #1323
Merged
Issues/1246 #1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
reviewed
Aug 22, 2017
| @@ -24,7 +23,7 @@ | |||
| * @author Vincent Chalamon <[email protected]> | |||
| * | |||
| * @ApiResource(attributes={ | |||
| * "order"={"name", "DESC"} | |||
| * "order"={"bar": "ASC", "name": "DESC"} | |||
There was a problem hiding this comment.
Just some nitpicking 😬: it would be great to also allow "order"={"bar", "name"} (that would be equivalent to "order"={"bar": "ASC", "name": "ASC"}. It's just some syntactic sugar but it improves the overall DX.
There was a problem hiding this comment.
@dunglas Could it also be interesting to order by association property, like dummy.name?
Simperfit
approved these changes
Aug 22, 2017
meyerbaptiste
approved these changes
Aug 22, 2017
|
Thanks @vincentchalamon |
Merged
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
* Fix api-platform#1246 after merge * Fix api-platform#1246: add default order, allow multiple orders with optional direction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.