fix #1479 allow to override SubresourceOperations through metadata #1483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
commented
Nov 8, 2017
| @@ -87,6 +87,9 @@ public function load($data, $type = null): RouteCollection | |||
|
|
|||
| if (null !== $collectionOperations = $resourceMetadata->getCollectionOperations()) { | |||
| foreach ($collectionOperations as $operationName => $operation) { | |||
| if ('subresource' === substr($operationName, -11)) { | |||
There was a problem hiding this comment.
Either this or we add a SubresourceOperations in the resource metadata declarations. Lmk.
There was a problem hiding this comment.
I think subresourceOperations would make more sense.
soyuka
force-pushed
the
fix-subresource-override-operation
branch
from
3a8c6c7 to
683d6fc
Compare
soyuka
changed the title
dunglas
reviewed
Nov 8, 2017
| /** | ||
| * Returns a new instance with the given subresource operations. | ||
| * | ||
| * @param array $subresourceOperations |
There was a problem hiding this comment.
You can remove those annotations (it's already documented by typehints).
There was a problem hiding this comment.
copy pasted, why don't we remove the other ones then?
dunglas
reviewed
Nov 8, 2017
| @@ -193,6 +220,21 @@ public function getItemOperationAttribute(string $operationName = null, string $ | |||
| } | |||
|
|
|||
| /** | |||
| * Gets a subresource operation attribute, optionally fallback to a resource attribute. | |||
| * | |||
| * @param string|null $operationName | |||
dunglas
approved these changes
Nov 8, 2017
soyuka
force-pushed
the
fix-subresource-override-operation
branch
2 times, most recently
from
97ef0bc to
94a420a
Compare
meyerbaptiste
approved these changes
Nov 16, 2017
| '', | ||
| [], | ||
| ['GET'] | ||
| ] + ($operation['defaults'] ?? []), |
There was a problem hiding this comment.
All parenthesis are useless here.
soyuka
force-pushed
the
fix-subresource-override-operation
branch
from
94a420a to
17c321f
Compare
|
Thanks @soyuka |
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
…ride-operation fix api-platform#1479 allow to override SubresourceOperations through metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also backported #1472 to subresources