Use Brigade for coverage #1505

meyerbaptiste · 2017-11-21T09:39:35Z

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	I hope
Fixed tickets	#1489
License	MIT
Doc PR	N/A

soyuka · 2017-11-21T09:42:01Z

brigade.js

+        'export COMPOSER_ALLOW_SUPERUSER=1',
+        'curl -s -f -L -o /tmp/installer.php https://getcomposer.org/installer',
+        'curl -s -f -L -o /tmp/install.sig https://composer.github.io/installer.sig',
+        'php -r "\$signature = trim(file_get_contents(\'/tmp/install.sig\')); \$hash = hash(\'SHA384\', file_get_contents(\'/tmp/installer.php\')); if (!hash_equals(\$signature, \$hash)) { unlink(\'/tmp/installer.php\'); echo \'Integrity check failed, installer is either corrupt or worse.\' . PHP_EOL; exit(1); }"',


Can't we use template strings? Would keep us from escaping the ' and allow multi lines on complex tasks like this one.

alanpoulain · 2017-11-21T10:03:32Z

Shouldn't we handle the versions used (for php-code-coverage or coveralls for example) elsewhere?

dunglas · 2017-11-21T10:12:04Z

brigade.js

+const coverage = (event, project) => {
+    console.log(`===> Building ${ project.repo.cloneURL } ${ event.commit }`);
+
+    const job = new Job('coverage', 'php:rc-alpine');


Maybe can you start from the composer image directly?

👍 Like I did in the DockerFile: https://gist.github.com/soyuka/6aa9da5649907372279a88e4eb0555ef

We should use a custom Docker image stored on the coopTilleuls account to save some CPU and speed up the builds.

Done @dunglas. Can you please review?

dunglas · 2017-11-21T10:15:22Z

@alanpoulain, in the end, we should probably use a pre-built Docker image containing all those tools to speed up the builds.

meyerbaptiste · 2017-11-21T11:27:37Z

Anyway, it doesn't work for now 😢

meyerbaptiste · 2017-11-22T02:20:42Z

It works!

Simperfit · 2017-11-22T06:17:46Z

I'm glad that this is working, congrats @meyerbaptiste !

dunglas · 2017-11-22T07:42:16Z

Wouhou!

Gregcop1 · 2017-11-22T08:03:11Z

brigade.js

+    const job = new Job('coverage', 'php:rc-alpine');
+
+    job.tasks = [
+        `set -xe`,


it's ok to use backticks for multiple lines but you can keep simple quotes here

sroze · 2017-11-22T09:16:30Z

But... the brigade commit status is a 404 URL and has Kevin's face on it 😄

sroze · 2017-11-22T09:21:02Z

What is the point of this by the way? 🤔 (Except the fancyness that I like 😛)

dunglas · 2017-11-22T09:30:52Z

What is the point of this by the way? 🤔 (Except the fancyness that I like 😛)

We cannot compute the code coverage on Travis anymore (we consume too much resources). So we use Brigade to compute the coverage.

Gregcop1 · 2017-11-22T09:44:53Z

A brigade with @dunglas as avatar is not something you see every day :p

soyuka · 2017-11-22T10:32:23Z

What is the point of this by the way? 🤔 (Except the fancyness that I like 😛)

The full story: https://gist.github.com/soyuka/2c6d55da59b1ab74a9a92deed093df02

meyerbaptiste · 2017-11-22T11:10:46Z

@sroze:

the brigade commit status is a 404 URL

See brigadecore/brigade#126.
Another problematic issue is brigadecore/brigade#125.

has Kevin's face on it

Yes it sounds weird but it's because the Github token used comes from @dunglas' account. Maybe we should create a specific account for API Platform?

soyuka · 2017-11-22T15:37:03Z

brigade.js

+        'composer require --dev --no-update \'phpunit/php-code-coverage:^5.2.2\'',
+        'composer update --prefer-dist --no-progress --no-suggest --ansi',
+        'phpdbg -qrr vendor/bin/phpunit --coverage-php build/cov/coverage-phpunit.cov',
+        'for f in $(find features -name \'*.feature\'); do FEATURE=${f//\\//_} phpdbg -qrr vendor/bin/behat --format=progress --profile coverage $f || exit $?; done',


here literals

soyuka · 2017-11-22T15:37:11Z

brigade.js

+        'set -xe',
+        'cd /src/',
+        'mkdir -p build/logs build/cov',
+        'composer require --dev --no-update \'phpunit/php-code-coverage:^5.2.2\'',


here literals

soyuka · 2017-11-22T15:37:50Z

brigade.js

+    job.env = {
+        'COVERALLS_RUN_LOCALLY': '1',
+        'COVERALLS_REPO_TOKEN': project.secrets.coverallsToken,
+    };


quotes are not needed on keys

soyuka · 2017-11-23T09:58:09Z

🎆 thanks @meyerbaptiste!

sroze · 2017-11-23T10:29:39Z

The 404 link is expected?

meyerbaptiste · 2017-11-23T10:32:26Z

@sroze: #1505 (comment) 😛

sroze · 2017-11-23T10:32:59Z

🙊 🏃

soyuka · 2017-11-23T11:11:16Z

@sroze anyway not a problem because this is only to keep the coverage up to date, we don't really care about the job itself :).

Use Brigade for coverage

soyuka reviewed Nov 21, 2017

View reviewed changes

meyerbaptiste force-pushed the add_brigade branch from 8765468 to 874b259 Compare November 21, 2017 09:55

dunglas reviewed Nov 21, 2017

View reviewed changes

soyuka mentioned this pull request Nov 21, 2017

Fix for custom identifier DBAL Type (oracle) #1503

Merged

meyerbaptiste force-pushed the add_brigade branch 6 times, most recently from fa214ba to b677b33 Compare November 22, 2017 02:07

meyerbaptiste changed the title ~~[WIP] Use Brigade for coverage~~ Use Brigade for coverage Nov 22, 2017

Simperfit approved these changes Nov 22, 2017

View reviewed changes

dunglas approved these changes Nov 22, 2017

View reviewed changes

Gregcop1 reviewed Nov 22, 2017

View reviewed changes

meyerbaptiste added 3 commits November 22, 2017 12:36

Use Brigade for coverage

55a4eb0

Remove coverage in Travis

72f5de5

Fix JS CS

3bcf2bc

meyerbaptiste force-pushed the add_brigade branch from 8a03f8c to 3bcf2bc Compare November 22, 2017 11:38

meyerbaptiste added the [WFC] Waiting for Change label Nov 22, 2017

meyerbaptiste force-pushed the add_brigade branch 5 times, most recently from ff06c86 to 9bed330 Compare November 22, 2017 14:22

Use a custom Docker image to speed up the builds

c04904f

meyerbaptiste force-pushed the add_brigade branch from 9bed330 to c04904f Compare November 22, 2017 15:32

soyuka reviewed Nov 22, 2017

View reviewed changes

Fix JS CS

bb5bcbe

meyerbaptiste force-pushed the add_brigade branch from 5d6cef9 to bb5bcbe Compare November 22, 2017 15:46

soyuka approved these changes Nov 22, 2017

View reviewed changes

meyerbaptiste added [RFR] Ready for Review and removed [WFC] Waiting for Change labels Nov 22, 2017

soyuka merged commit e69d857 into api-platform:2.0 Nov 23, 2017

meyerbaptiste deleted the add_brigade branch November 23, 2017 10:27

hoangnd25 pushed a commit to hoangnd25/core that referenced this pull request Feb 23, 2018

Merge pull request api-platform#1505 from meyerbaptiste/add_brigade

403ee1d

Use Brigade for coverage

Uh oh!

Use Brigade for coverage #1505

Use Brigade for coverage #1505

Uh oh!

Conversation

meyerbaptiste commented Nov 21, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alanpoulain commented Nov 21, 2017

Uh oh!

dunglas Nov 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dunglas commented Nov 21, 2017

Uh oh!

meyerbaptiste commented Nov 21, 2017

Uh oh!

meyerbaptiste commented Nov 22, 2017

Uh oh!

Simperfit commented Nov 22, 2017

Uh oh!

dunglas commented Nov 22, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sroze commented Nov 22, 2017

Uh oh!

sroze commented Nov 22, 2017

Uh oh!

dunglas commented Nov 22, 2017

Uh oh!

Gregcop1 commented Nov 22, 2017

Uh oh!

soyuka commented Nov 22, 2017

Uh oh!

meyerbaptiste commented Nov 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soyuka commented Nov 23, 2017

Uh oh!

sroze commented Nov 23, 2017

Uh oh!

meyerbaptiste commented Nov 23, 2017

Uh oh!

sroze commented Nov 23, 2017

Uh oh!

soyuka commented Nov 23, 2017

Uh oh!

Uh oh!

dunglas Nov 21, 2017 •

edited

Loading

meyerbaptiste commented Nov 22, 2017 •

edited

Loading