[SymfonyBundle] Fixed the configuration #1563
Conversation
| ->cannotBeEmpty() | ||
| ->defaultValue('') | ||
| ->end() | ||
| ->scalarNode('vesion') |
There was a problem hiding this comment.
Oups. Good catch. Thanks (We should never edit code on Github directly :p)
| ->scalarNode('version') | ||
| ->info('The version of the API.') | ||
| ->cannotBeEmpty() | ||
| ->defaultValue('') |
There was a problem hiding this comment.
Is there any reason to delete the old default value (0.0.0)?
There was a problem hiding this comment.
Shame on me !
The reason: I copy paste the previous block. It's not fixed.
So Sorry
|
Can you rebase against 2.1, as it's a bug fix? Thanks! |
|
@dunglas Here we go ;) |
| ->scalarNode('title') | ||
| ->info('The title of the API.') | ||
| ->cannotBeEmpty() | ||
| ->defaultValue('') |
There was a problem hiding this comment.
isn't it useless given the node that cannot be empty?
There was a problem hiding this comment.
In fact we must allow empty strings, but not null. Maybe should be just normalize all empty values to ''?
There was a problem hiding this comment.
IMHO, the config here is simpler than normalizing everything ...
There was a problem hiding this comment.
but forbids empty strings, thus breaks with the default value
There was a problem hiding this comment.
I agree we must allow empty strings or it will be a big BC break (for instance the Flex recipe doesn’t set those keys).
|
I don't think failing test is related, maybe a rebase would fix CI. |
The value of title/description/version should not be empty.
If there are empty, we got the following exception:
```
Type error: Argument 8 passed to ApiPlatform\Core\Bridge\Symfony\Bundle\Action\SwaggerUiAction::__construct() must be of the type string, null given, called in /var/www/server/backend/var/cache/dev/appDevDebugProjectContainer.php on line 1155
```
How to reproduce:
```
#config.yml
api_platform:
title: #nothing explicitly
```
|
I just rebased. |
|
Thanks @lyrixx ! |
Fix null title/description configuration (#1563 followup)
[SymfonyBundle] Fixed the configuration
Fix null title/description configuration (api-platform#1563 followup)
The value of title/description/version should not be empty.
If there are empty, we got the following exception:
How to reproduce: