Implement the Relay Global Object Identification Specification #1585
Conversation
src/Graphql/Type/SchemaBuilder.php
Outdated
| $this->itemMutationResolverFactory = $itemMutationResolverFactory; | ||
| $this->defaultFieldResolver = $defaultFieldResolver; | ||
| $this->paginationEnabled = $paginationEnabled; | ||
| } | ||
|
|
||
| public function getSchema(): Schema | ||
| { | ||
| $queryFields = []; | ||
| $nodeInterface = $this->getNodeInterface(); |
There was a problem hiding this comment.
Why not storing the type in $graphqlTypes instead of passing it in all the methods?
src/Graphql/Type/SchemaBuilder.php
Outdated
| ], | ||
| ], | ||
| 'resolveType' => function ($value) { | ||
| if (!isset($value['#item'])) { |
There was a problem hiding this comment.
Maybe #item should be a const.
src/Graphql/Type/SchemaBuilder.php
Outdated
| @@ -179,17 +226,20 @@ private function getResourceFieldConfiguration(string $fieldDescription = null, | |||
| 'resolve' => $resolve, | |||
| ]; | |||
| } catch (InvalidTypeException $e) { | |||
| return null; | |||
| // return null | |||
| } | ||
|
|
||
| /** | ||
| * Gets the fields of the type of the given resource. | ||
| */ | ||
| private function getResourceObjectTypeFields(string $resource, bool $isInput = false, bool $isMutation = false, string $mutationName = null): array | ||
| private function getResourceObjectTypeFields(string $resource, bool $input = false, string $mutationName = null): array | ||
| { | ||
| $fields = []; | ||
| $idField = ['type' => GraphQLType::id()]; |
There was a problem hiding this comment.
This should be wrapped by GraphQLType::nonNull() as it implements Relay Node interface now, and Node.id required to be nonNull. Commenting here as I'm not sure how much you have progressed after this commit, will submit PR if required. Thank you for all your work!
P.S. Line in question is 328, ['type' => GraphQLType::id()] should be ['type' => GraphQLType::nonNull(GraphQLType::id())]
There was a problem hiding this comment.
This has not be fixed. Can I let you do the PR? Thanks for the review!
There was a problem hiding this comment.
@dunglas saw you already did that, though it would be faster for you anyway, as you were still working in that file :) Thank you for all your work once again! Waiting for your blog entry on GraphQL :) have a good weekend 🎉
Implementation of the GraphQL's Relay Global Object Identification Specification using hypermedia IRIs.
You can now execute this kind of queries on the GraphQL endpoint:
{ node(id: "/product/ABC") { id ... on Product { name } } }Note: I'll probably extract the GraphQL type builder in a from the
SchemaBuilderin a following PR.