Support YAML output from SwaggerCommand with --yaml #1695
Conversation
There was a problem hiding this comment.
Can you also add a test in the CI (like https://github.com/api-platform/core/blob/master/.travis.yml#L56) to check with the Swagger validator that the generated YAML file is valid?
| @@ -63,7 +66,11 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| { | |||
| $documentation = new Documentation($this->resourceNameCollectionFactory->create(), $this->apiTitle, $this->apiDescription, $this->apiVersion, $this->apiFormats); | |||
| $data = $this->documentationNormalizer->normalize($documentation); | |||
| $content = json_encode($data, JSON_PRETTY_PRINT); | |||
| if ($input->getOption('yaml')) { | |||
There was a problem hiding this comment.
$input->getOption('yaml') ? Yaml::dump($data) : json_encode($data, JSON_PRETTY_PRINT?
There was a problem hiding this comment.
If you insist. 👍 I try to avoid those.
Sure. Edit: good call, it seems to be invalid. |
dkarlovi
force-pushed
the
swagger-command-yaml
branch
from
66cbedd to
e249e86
Compare
|
It seems like this is the output: swagger: '2.0'
basePath: /
info:
title: 'My Dummy API'
version: 0.0.0
description: 'This is a test API.'
paths: null
definitions: nullwhile this is supposed to be the output: swagger: '2.0'
basePath: /
info:
title: 'My Dummy API'
version: 0.0.0
description: 'This is a test API.'
paths: {}
definitions: {}I've added |
|
@dunglas Don't forget to merge this since you merged the docs describing it already. :) |
|
Thanks @dkarlovi |
Closes #1688.