Fix initialization of the serialization context

[meyerbaptiste]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	N/A
License	MIT
Doc PR	N/A

According to

core/src/EventListener/ReadListener.php

Line 73 in fb7cc47

$context['normalization_context'] = $this->serializerContextBuilder->createFromRequest($request, true, $attributes);

, the normalization context array is in the normalization_context index of the context array. So, if we pass the whole context array to the EagerLoadingExtension::joinRelations() method, we can't properly retrieve groups, max depth and attributes.

[meyerbaptiste]

Okay, it doesn't work in the case of deserialization... I'll investigate.

[meyerbaptiste]

I think we should fix this in the ReadListener class instead, like that it should work with deserialization too.
Indeed, when we call IriConverterInterface::getItemFromIri() during deserialization for example, the denormalization context is at first level in the context array and not in a denormalize_context index.

- $context['normalization_context'] = $this->serializerContextBuilder->createFromRequest($request, true, $attributes);
+ $context += $this->serializerContextBuilder->createFromRequest($request, true, $attributes);

But it looks like a BC Break to remove this key, isn't it?

WDYT @api-platform/core-team?

[soyuka]

+1 about the second option. I'm not sure that this context is exposed to the public, I mean isn't it an internal thing only?

[meyerbaptiste]

Huum, not really. It's exposed when you implement ContextAwareQueryCollectionExtensionInterface and ContextAwareCollectionDataProviderInterface for example...

[dunglas]

👍 for the second option. It's kinda internal and it has been introduced in 2.2. It's now or never...

[soyuka]

needs to target 2.2 as a bug fix then?

[meyerbaptiste]

Right, I missed this branch...

[dunglas]

Thanks @meyerbaptiste