Skip to content

Expose Pagination in Swagger UI #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2018

Conversation

ragboyjr
Copy link
Contributor

fixes #2161

Signed-off-by: RJ Garcia [email protected]

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #2161
License MIT
Doc PR

Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also check why the tests are red please?

@@ -635,6 +642,20 @@ private function getPaginationParameters(): array
];
}

/**
* Returns enable pagination parameter for the "get" collectionn operation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

collection

@ragboyjr ragboyjr force-pushed the expose-pagination-in-swagger-ui branch 2 times, most recently from 00276a8 to 29558f2 Compare August 23, 2018 17:50
Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement. Can you run php-cs-fixer fix please?

@dunglas dunglas force-pushed the expose-pagination-in-swagger-ui branch from 29558f2 to ace413d Compare September 11, 2018 15:55
@dunglas dunglas merged commit fd93636 into api-platform:master Sep 11, 2018
@dunglas
Copy link
Member

dunglas commented Sep 11, 2018

Thank you @ragboyjr!

@ragboyjr ragboyjr deleted the expose-pagination-in-swagger-ui branch September 19, 2018 00:57
epourail pushed a commit to epourail/fork-apiplatform-core that referenced this pull request Sep 25, 2018
* Expose Pagination in Swagger UI

fixes api-platform#2161

Signed-off-by: RJ Garcia <[email protected]>

* Fix CS
soyuka pushed a commit to CvekCoding/core that referenced this pull request Nov 2, 2018
* Expose Pagination in Swagger UI

fixes api-platform#2161

Signed-off-by: RJ Garcia <[email protected]>

* Fix CS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pagination_client_enabled true doesn't expose pagination parameter in swagger UI
2 participants