Skip to content

Don't run phpunit tests on Travis #3054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 15, 2019

Conversation

teohhanhui
Copy link
Contributor

@teohhanhui teohhanhui commented Sep 6, 2019

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

Since they're already run in the CI workflow on GitHub Actions

TODO:

  • Move the rest of the phpunit tests to GitHub Actions too, perhaps?

@teohhanhui
Copy link
Contributor Author

Jobs with 7.4snapshot on Travis are failing. Not sure if it's a problem with their build of PHP 7.4.


- name: 'Behat (PHP 7.4-rc) (lowest dependencies)'
php: '7.4snapshot'
env: LEGACY=0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dunglas Is this okay? At least until michelf/php-markdown#316 is released?

@teohhanhui
Copy link
Contributor Author

teohhanhui commented Sep 20, 2019

Behat on PHP 7.4 is still broken. We need to wait for the next Twig 2.x release: twigphp/Twig#3151

@teohhanhui teohhanhui force-pushed the make-ci-fast-again branch 4 times, most recently from 471ac4c to daae8fe Compare September 23, 2019 09:45
@teohhanhui
Copy link
Contributor Author

teohhanhui commented Sep 23, 2019

Other failures should have been fixed. Waiting for next Twig 2.x release...

Edit: Twig 2.12 was released.

@teohhanhui teohhanhui force-pushed the make-ci-fast-again branch 2 times, most recently from ab22a7e to 7096630 Compare September 27, 2019 10:28
@teohhanhui teohhanhui force-pushed the make-ci-fast-again branch 3 times, most recently from 0adf77e to f823b1f Compare October 12, 2019 10:46
@teohhanhui
Copy link
Contributor Author

teohhanhui commented Oct 12, 2019

Still targeting 2.4 as this does not change any code, only our test suite (minor), but mostly CI stuff.

We can demonstrate that 2.4 is actually compatible with PHP 7.4

Since they're already run in the CI workflow on GitHub Actions
@teohhanhui teohhanhui force-pushed the make-ci-fast-again branch 2 times, most recently from 2e7a6b9 to b81ca8d Compare October 14, 2019 12:14
@teohhanhui teohhanhui force-pushed the make-ci-fast-again branch 10 times, most recently from 10c9b1d to 024de42 Compare October 14, 2019 18:42
@teohhanhui teohhanhui force-pushed the make-ci-fast-again branch 8 times, most recently from fcc5d8f to 2068ac9 Compare October 15, 2019 09:52
@teohhanhui
Copy link
Contributor Author

Healthcheck for elasticsearch container finally fixed lol

@teohhanhui teohhanhui merged commit 1607fc7 into api-platform:2.4 Oct 15, 2019
@teohhanhui teohhanhui deleted the make-ci-fast-again branch October 15, 2019 17:18
@teohhanhui teohhanhui mentioned this pull request Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants