Update thrown exception and clarify error message for UuidNormalizer. #3132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in issue api-platform#3045, the given error message was misleading. I also updated the thrown exception according to the Exception mentioned in the same issue. Of course I updated the related PHPUnit test too.
Taminoful
changed the title
Taminoful
changed the title
|
Currently fixing a behat testcase I've overlooked. |
soyuka
requested changes
Oct 4, 2019
Taminoful
added a commit
to Taminoful/core
that referenced
this pull request
Oct 4, 2019
As discussed in PR api-platform#3132, the thrown exception should stay as InvalidIdentifierException only the error message should be clarified.
Taminoful
added a commit
to Taminoful/core
that referenced
this pull request
Oct 4, 2019
Updated the error message as discussed in PR api-platform#3132.
I overlooked the behat test which fails since I didn't update the error code which is thrown by the exception.
teohhanhui
approved these changes
Oct 4, 2019
soyuka
approved these changes
Oct 6, 2019
|
Thanks @Taminoful ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #3045, the given error message was misleading.
I also updated the thrown exception according to the Exception
mentioned in the same issue. Of course I updated the related PHPUnit
test too.