Skip to content

#3577 moved content negotiation to before firewall #3599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kralos
Copy link
Contributor

@kralos kralos commented Jun 15, 2020

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tickets fixes #3577
License MIT
Doc PR

Moved content negotiation to before firewall to allow content aware security responses.

@kralos kralos marked this pull request as draft June 17, 2020 00:27
@kralos kralos force-pushed the 3577-content-negotiation-firewall branch from 61e1bb4 to 9153f00 Compare June 17, 2020 01:15
@kralos kralos marked this pull request as ready for review June 17, 2020 02:19
@kralos
Copy link
Contributor Author

kralos commented Jun 17, 2020

CI appears to be failing the same on branch 2.5 (base)

I found a bug in features/filter/filter_validation.feature

This is effectively using the default format ('application/ld+json') because it's the first format in tests/Fixtures/app/config/config_common.yml api_platform.formats

@dunglas
Copy link
Member

dunglas commented Jul 10, 2020

Shouldn't we explicitly set the Accept and header instead of changing the test?
Also could you add a specific test covering your change to prevent any future regression please?

@soyuka soyuka added the waiting label Jul 23, 2020
@soyuka soyuka removed the waiting label Feb 19, 2021
@alanpoulain alanpoulain changed the base branch from 2.5 to 2.6 March 2, 2021 13:39
@alanpoulain alanpoulain force-pushed the 3577-content-negotiation-firewall branch 2 times, most recently from 10e65b6 to 264075a Compare March 2, 2021 15:41
@alanpoulain alanpoulain changed the base branch from 2.6 to main March 2, 2021 16:18
@alanpoulain alanpoulain force-pushed the 3577-content-negotiation-firewall branch from 264075a to 3e0365b Compare March 2, 2021 16:25
@alanpoulain alanpoulain merged commit 6f88fb4 into api-platform:main Mar 2, 2021
@alanpoulain
Copy link
Member

Thanks @kralos. Hopefully it will be not a BC break too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content Negotiation should be performed before Authentication / FirewallListener
4 participants