Allow serializing when property and method start from "is"

[maks-rafalko]

Q	A
Branch?	2.6
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

Follow up for https://github.com/api-platform/core/pull/4064/files

In #4064, there was a fix for documentation generated on UI. But, unfortunately, when we use public function isActive() method and $isActive property, the value is not being serialized - it is not included in the response.

The reason is the same - $options array does not contain 'enable_getter_setter_extraction' => true default value.

I have some issues with the tests, probably you can help me with understanding what's going on, will comment below.

[maks-rafalko]

I have no idea where dummyBoolean serialized key/value comes from.

If I remove the fix ('enable_getter_setter_extraction' => true) - both isDummyBoolean and DummyBoolean are absent.

Is it something json-ld adds in addition to isDummyBoolean?

I can't reproduce it locally on 2.6.3 in our project (we use application/json)

[alanpoulain]

I think it's more a normalizer issue and it should be fixed in Symfony itself.
I saw it too when debugging the previous PR.

[maks-rafalko]

Oh, I think I understand why I can't reproduce it locally - because we have a composer.lock and our serializer doesn't have this bug, while api-platform/core installs the latest versions

[alanpoulain]

Wouldn't it be better in serializer?

[alanpoulain]

The unit tests need to be fixed too.

[soyuka]

we should avoid changing old tests

[soyuka]

wondering if this should be opt-in, does this break existing tests?

[alanpoulain]

No it doesn't break existing tests. However it can be considered as a BC break.

[alanpoulain]

I think this feature should probably target 2.7 and can be considered as a BC break.
For instance if you have an entity like this:

<?php

use ApiPlatform\Core\Annotation\ApiResource;
use Doctrine\ORM\Mapping as ORM;

/**
 * @ApiResource
 * @ORM\Entity
 */
class Test
{
    /**
     * @var int
     *
     * @ORM\Column(type="integer", nullable=true)
     * @ORM\Id
     * @ORM\GeneratedValue(strategy="AUTO")
     */
    private $id;

    /**
     * @var bool
     *
     * @ORM\Column(type="boolean", nullable=true)
     */
    private $last;

    public function getId()
    {
        return $this->id;
    }

    public function last(): bool
    {
        return $this->last;
    }
}

Before it was not serialized and now it will be. WDYT @maks-rafalko @soyuka?

[alanpoulain]

As @soyuka said we could make it opt-in too.
We should change what #4064 is doing too to reflect what we do here.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[maks-rafalko]

@Stale

It still the issue, however I don't have time/energy to complete it. If someone can help, that would be awesome.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.