OpenAPI: Make sure we do not override defined parameters #4137 #4138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
fix/openapi-fixes
branch
4 times, most recently
from
5f11d6c to
127e0bf
Compare
alanpoulain
reviewed
Mar 16, 2021
alanpoulain
reviewed
Mar 16, 2021
alanpoulain
force-pushed
the
fix/openapi-fixes
branch
from
7e7d6e2 to
d57626f
Compare
alanpoulain
approved these changes
Mar 16, 2021
|
Thank you! |
| @@ -83,7 +83,7 @@ public function getDeprecated(): bool | |||
| return $this->deprecated; | |||
| } | |||
|
|
|||
| public function canAllowEmptyValue(): bool | |||
| public function getAllowEmptyValue(): bool | |||
There was a problem hiding this comment.
BC break? Did you intend to duplicate (like the other ones below) rather than rename the existing?
Update: #4203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves performances by 60% https://blackfire.io/profiles/compare/d6d1c64b-ec39-4ac9-ac9f-630dac371da4/graph