fix(metadata): defaults should not override values #4702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
silverbackdan
commented
Apr 4, 2022
silverbackdan
commented
| Q | A |
|---|---|
| Branch? | main |
| Tickets | #4699 |
| License | MIT |
| Doc PR | n/a |
| Fix: #4699 |
…ults - do not overwrite operation properties with defaults
silverbackdan
changed the title
silverbackdan
changed the title
silverbackdan
changed the title
alanpoulain
reviewed
Apr 4, 2022
alanpoulain
reviewed
Apr 4, 2022
Comment on lines
174
to
177
| $upperProperty = ucfirst($key); | ||
| $getter = "get$upperProperty"; | ||
|
|
||
| if (method_exists($operation, $getter) && null === $operation->{$getter}()) { |
There was a problem hiding this comment.
I think just changing the condition would have been alright.
alanpoulain
reviewed
Apr 4, 2022
Comment on lines
+28
to
+32
| #[GetCollection( | ||
| paginationClientItemsPerPage: true, | ||
| paginationItemsPerPage: 5, | ||
| paginationMaximumItemsPerPage: 30 | ||
| )] |
There was a problem hiding this comment.
You cannot use PHP 8 attributes directly in the tests, you need to use annotations like before, they will be automatically converted to PHP attributes by our command (api:upgrade-resource).
There was a problem hiding this comment.
you can you just need to flag them as @php8 tests :)
soyuka
changed the title
|
Thank you both :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.