Fix SwaggerCommandTest #836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
force-pushed
the
fix_swagger_cmd_test
branch
from
d4dc4f9 to
a380d0a
Compare
Simperfit
approved these changes
Nov 8, 2016
| use Symfony\Component\Console\Tester\ApplicationTester; | ||
|
|
||
| /** | ||
| * @author Amrouche Hamza <[email protected]> | ||
| */ | ||
| class SwaggerComandTest extends WebTestCase | ||
| class SwaggerCommandTest extends KernelTestCase |
There was a problem hiding this comment.
Good catch ! I didn't see that in the first place
teohhanhui
reviewed
Nov 9, 2016
| $application = new Application(static::$kernel); | ||
| $application->setCatchExceptions(false); | ||
| $application->setAutoExit(false); | ||
|
|
||
| $tester = new ApplicationTester($application); |
There was a problem hiding this comment.
I think https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Tester/CommandTester.php is the right helper to use here.
magarzon
pushed a commit
to magarzon/core
that referenced
this pull request
Feb 12, 2017
Fix SwaggerCommandTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @Simperfit