Fix the entrypoint missing the path prefix #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
reviewed
Apr 6, 2019
Deuchnord
force-pushed
the
fix/entrypoint-with-path-prefix
branch
2 times, most recently
from
6548698 to
0d88c6f
Compare
alanpoulain
reviewed
Apr 6, 2019
Deuchnord
force-pushed
the
fix/entrypoint-with-path-prefix
branch
from
0d88c6f to
0d6cb54
Compare
Deuchnord
force-pushed
the
fix/entrypoint-with-path-prefix
branch
from
0d6cb54 to
271700f
Compare
alanpoulain
approved these changes
Apr 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you create an app with your API endpoints on a subpath, for instance,
http://yoursite.tld/api, the/apipart of the URL was lost because of a behaviour of the JSURLprototype.This PR solves that. Basically, it checks if the ENTRYPOINT has a trailing slash. If it doesn’t, the trailing slash is added, so the path is well appended to the URL.
Plus, we now use the
URL.hrefproperty instead of thetoString()function.