Skip to content

Add Quasar Framework generator. #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 9, 2019
Merged

Add Quasar Framework generator. #134

merged 9 commits into from
Jun 9, 2019

Conversation

devel-pa
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Adding Quasar Framework generator.

@dunglas
Copy link
Member

dunglas commented Jun 8, 2019

Wow, awesome! Thank you very much for contributing this generator. I don't know Quasar enough to do an efficient review, but I propose to merge it as is. If we attract some Quasar contributors, they'll be able to open PR to improve this generator if needed. WDYT @api-platform/core-team?

@devel-pa can you open a docs PR please?

@devel-pa
Copy link
Contributor Author

devel-pa commented Jun 8, 2019

Hi, PR opened.

api-platform/docs#836

@sroze
Copy link

sroze commented Jun 9, 2019

I don't know Quasar enough to do an efficient review, but I propose to merge it as is. If we attract some Quasar contributors, they'll be able to open PR to improve this generator if needed.

Sounds like a good option 👍

@fogx
Copy link

fogx commented Jun 9, 2019

also very interested in seeing this be merged

@dunglas dunglas merged commit 4b0e135 into api-platform:master Jun 9, 2019
@dunglas
Copy link
Member

dunglas commented Jun 9, 2019

Thanks @devel-pa!

@devel-pa
Copy link
Contributor Author

Thanks guys for API Platform.

@nothingismagick
Copy link

nothingismagick commented Jun 15, 2019

Hi, I'm from the Quasar core team. This is a nice idea and I love api-platform, but I have a pretty strong opinion about this approach - namely that it could be MUCH better and actually be tightly integrated into the Quasar ecosystem instead of "patched" in this manner.

We have the concept of app-extensions - which allow you to inject templated files and additional dependencies during the installation phase, and even tamper with webpack conf or any other part of the quasar.conf CTX at runtime during dev HMR or build. You can generate and start backends and APIs, run vulnerability tests etc. etc. Since you are already requiring the global use of the @quasar/cli in the docs, it seems like a no-brainer to go the proper route.

This is why I think that it would be better to have an official API-PLATFORM App Extension to manage this, because then there is less template maintenance and it will not get stale as development of Quasar progresses.

If you like, visit us on our discord channel and ask for me @nothingismagick - I'm willing to help you do this right.


P.S. @dunglas - If you want to see a recent comparison between Quasar-CLI managed project and Vue-CLI (with Vuetify) - check out this recent article:
https://medium.com/quasar-framework/migrating-from-vuetify-to-quasar-bcc1fe85763d

@devel-pa
Copy link
Contributor Author

devel-pa commented Jun 17, 2019

@nothingismagick

Hi,

Since you are already requiring the global use of the @quasar/cli in the docs: it is for starting a new app as quasar docs stated. Not used by generator.

during the installation phase: usually I have no API at that moment, probably I'm missing something but I don't want/need any code generator (other than plain Quasar) at that point.

it would be better to have an official API-PLATFORM App Extension: could be. There is any example of an extension that adds a command to the CLI (anything that could be generated later)?

Thanks,

Paul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants