Skip to content

Allow multiple generators #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2017
Merged

Allow multiple generators #21

merged 1 commit into from
Sep 14, 2017

Conversation

soyuka
Copy link
Member

@soyuka soyuka commented Sep 14, 2017

No description provided.

@@ -0,0 +1,5131 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really necessary? We use yarn for all other packages.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not using yarn and this speeds up builds. I wish we could stick with default tools. Yarn should be the one using the package-lock instead of his custom lock file IMO...

https://hackernoon.com/its-ok-to-not-use-yarn-f28dc766ef32

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it will be a pain to maintain both a yarn.lock and a package-lock.json file. Yarn is pre-installed in the Node Docker image and in Travis.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though npm already comes with nodejs ^^. File removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn.lock must be updated now 😂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(master ✗)❯ yarn
zsh: command not found: yarn

I don't want it 😆. Updated but really this is a pain.

@dunglas
Copy link
Member

dunglas commented Sep 14, 2017

Thanks @soyuka

@dunglas dunglas merged commit b27ef67 into api-platform:master Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants