refacto: moved title meta tag in pages #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Mar 17, 2021
| <div> | ||
| <Head> | ||
| <title>{ {{{lc}}} && `Edit {{{ucf}}} ${ {{~lc}}['@id']}`}</title> | ||
| <meta property="og:title" content={ {{{lc}}} && `Edit{{{ucf}}} ${ {{~lc}}['@id']}`} key="title" /> |
There was a problem hiding this comment.
Is this necessary if the content is the same as the <title> tag?
There was a problem hiding this comment.
It seems that the <title> tag is used by Google and meta property="og:title" is used by social medias.
(see: https://www.quora.com/In-terms-of-SEO-value-does-the-Open-Graph-meta-title-tag-meta-property-og-title-have-as-much-value-as-a-Title-tag-Can-we-leave-title-tag-out, it's an old thread but maybe still valid, see NextJS documentation examples about <Head /> component : https://nextjs.org/docs/api-reference/next/head)
dunglas
reviewed
Mar 24, 2021
| <div> | ||
| <div> | ||
| <Head> | ||
| <title>{`Show {{{ucf}}} ${ {{~lc}}['@id']}`}</title> |
There was a problem hiding this comment.
Suggested change
| <title>{`Show {{{ucf}}} ${ {{~lc}}['@id']}`}</title> | |
| <title>{`Show {{{ucf}}} ${ {{~lc}}['@id']}`}</title> |
dunglas
approved these changes
Mar 24, 2021
|
Thanks @justinezahiri |
justinezahiri
added a commit
to justinezahiri/api-platform-client-generator
that referenced
this pull request
Aug 5, 2021
* refacto: moved title meta tag in pages * fixed typo in imports * removed og:title from Head
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #260
moved title meta tag in pages instead of components