fix: fine tuning ad fixes #319
Conversation
malikalahfaoui
commented
Mar 14, 2022
malikalahfaoui
commented
| Q | A |
|---|---|
| Branch? | main for features / current stable version branch for bug fixes |
| Tickets | #... |
| License | MIT |
| Doc PR | api-platform/docs#... |
| return { | ||
| paths, | ||
| fallback: true, | ||
| }; | ||
| } catch (e) { |
There was a problem hiding this comment.
response declared in try block but used outside
| @@ -54,29 +76,6 @@ export const getStaticPaths: GetStaticPaths = async () => { | |||
| fallback: true, | |||
| }; | |||
| } | |||
|
|
|||
| const view = response.data['{{{hydraPrefix}}}view']; | |||
There was a problem hiding this comment.
response declared in try block but used outside
| @@ -36,12 +36,13 @@ export const fetch = async (id: string, init: RequestInit = {}) => { | |||
| const resp = await isomorphicFetch(ENTRYPOINT + id, init); | |||
| if (resp.status === 204) return; | |||
|
|
|||
There was a problem hiding this comment.
TypeError: body used already for...
| @@ -2,15 +2,15 @@ import { FunctionComponent, useState } from 'react'; | |||
| import Link from 'next/link'; | |||
| import { useRouter } from "next/router"; | |||
| import { fetch } from "../../utils/dataAccess"; | |||
| import ReferenceLinks from '../common/ReferenceLinks'; | |||
There was a problem hiding this comment.
ReferenceLinks not used on Show.tsx I just cleaned the code
| await fetch(`/{{{name}}}?page=${page}`).data["{{{hydraPrefix}}}member"].map(({{{lc}}}) => `${ {{~lc}}['@id'] }/edit`) | ||
| ); | ||
| } | ||
| } catch (e) { |
There was a problem hiding this comment.
I think we can remove this try/catch then.
There was a problem hiding this comment.
Maybe should we move this complex logic to a helper function to avoid code duplication?
| await fetch(`/{{{name}}}?page=${page}`).data["{{{hydraPrefix}}}member"].map(({{{lc}}}) => `${ {{~lc}}['@id'] }`) | ||
| ); | ||
| } | ||
| } catch (e) { |
There was a problem hiding this comment.
Please remove this try/catch.
| return { | ||
| props: { | ||
| {{{lc}}}: await fetch(`/{{{name}}}/${params.id}`), | ||
| {{{lc}}}: response.data, |
There was a problem hiding this comment.
Isn't it better to pass the full response (including headers etc)?
There was a problem hiding this comment.
updated after the use of react query
| await fetch(`/{{{name}}}?page=${page}`).data["{{{hydraPrefix}}}member"].map(({{{lc}}}) => `${ {{~lc}}['@id'] }/edit`) | ||
| ); | ||
| } | ||
| } catch (e) { |
There was a problem hiding this comment.
Maybe should we move this complex logic to a helper function to avoid code duplication?
malikalahfaoui
force-pushed
the
fix/fineTuning
branch
6 times, most recently
from
ce0d1d7 to
f188d95
Compare
malikalahfaoui
force-pushed
the
fix/fineTuning
branch
from
1174136 to
d4f068e
Compare
alanpoulain
force-pushed
the
fix/fineTuning
branch
from
5e37f48 to
7a104f9
Compare
|
Thanks @malikalahfaoui! |
