Skip to content

Add Puppeteer #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 15, 2019
Merged

Add Puppeteer #55

merged 3 commits into from
Jan 15, 2019

Conversation

vincentchalamon
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #53

@vincentchalamon vincentchalamon self-assigned this Oct 17, 2018
@vincentchalamon vincentchalamon changed the title [WIP] Add Nightwatch.js Add Nightwatch.js Oct 17, 2018
dunglas
dunglas requested changes Oct 18, 2018
View reviewed changes
@vincentchalamon vincentchalamon mentioned this pull request Oct 22, 2018
Closed
@vincentchalamon vincentchalamon changed the title Add Nightwatch.js Add Puppeteer Dec 27, 2018
Gregcop1
Gregcop1 reviewed Jan 2, 2019
View reviewed changes
Gregcop1
Gregcop1 reviewed Jan 2, 2019
View reviewed changes
Gregcop1
Gregcop1 reviewed Jan 2, 2019
View reviewed changes
dunglas
dunglas reviewed Jan 14, 2019
View reviewed changes
dunglas
dunglas reviewed Jan 14, 2019
View reviewed changes
dunglas
dunglas approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@dunglas dunglas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding at least a real test would be nice

@vincentchalamon vincentchalamon merged commit b79601b into api-platform:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

@Gregcop1 Gregcop1 Gregcop1 approved these changes

@Mathieudewet Mathieudewet Mathieudewet approved these changes

Assignees

@vincentchalamon vincentchalamon

Labels
enhancement RFR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vincentchalamon @dunglas @Gregcop1 @Mathieudewet