Skip to content

Update "Changing Operations [...]" section #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 15, 2021
Merged

Update "Changing Operations [...]" section #1284

merged 7 commits into from
Feb 15, 2021

Conversation

yivi
Copy link
Contributor

@yivi yivi commented Feb 14, 2021

This section uses a configuration format that works for version 2 of OpenApi, which clashes with the default for the distribution (v3). The documentation example simply does not work out of the box.

Users updating are also being hit by this.

Included an example with attributes, instead of annotations, since we should always use the latest version of dependencies on documentation.

yivi and others added 2 commits February 14, 2021 19:13
[This section](https://api-platform.com/docs/core/openapi/#changing-operations-in-the-openapi-documentation) uses a configuration format that works for version 2 of OpenApi, which clashes with the default for the distribution (v3). The documentation example simply does not work out of the box.

Users updating are also being [hit by this](api-platform/core#4035).

Included an example with attributes, instead of annotations, since [we should always use the latest version of dependencies on documentation](#1272 (comment)).
@yivi
Copy link
Contributor Author

yivi commented Feb 14, 2021

The new swagger-ui-2.png is 100kb, because it's a bit taller to show the "example value" section. It's a bit heavy. A WebP version would be only 20kb, but since all other images are PNG I didn't want to add an image in a different version.

@alanpoulain
Copy link
Member

Hello, thank you for this PR 🙂

@alanpoulain alanpoulain merged commit ddee00d into api-platform:2.6 Feb 15, 2021
@alanpoulain
Copy link
Member

Thank you @yivi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants