Updated Mac env setting names for Xdebug v3 #1331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
reviewed
Mar 31, 2021
alanpoulain
reviewed
Mar 31, 2021
alanpoulain
reviewed
Mar 31, 2021
distribution/debugging.md
Outdated
| idekey=PHPSTORM | ||
| remote_autostart=1 | ||
| remote_mode=req | ||
| remote_handler=dbgp |
There was a problem hiding this comment.
I don't think this line is necessary, isn't it?
alanpoulain
reviewed
Mar 31, 2021
alanpoulain
reviewed
Mar 31, 2021
distribution/debugging.md
Outdated
| discover_client_host=0 | ||
| client_host=docker.for.mac.localhost | ||
| mode=debug | ||
| start_with_request=trigger |
There was a problem hiding this comment.
This is the default in debug mode, it should be removed as well.
|
Hi @alanpoulain, Thank you for reviewing my change. I took the decision to just replace - like for like - the setting names that were already listed on the docs page - even though some are default but I agree with your comments. I will make the changes. |
|
Hi @alanpoulain, I have made the changes (and tested locally on my machine) and works as expected, and docs look much simpler now. Thank you. |
alanpoulain
approved these changes
Mar 31, 2021
|
Thank you @rettal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the setting names to match Xdebug v3 setting names for Mac environments.