Skip to content

feat: Add documentation to test file uploads #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 13, 2021
Merged

feat: Add documentation to test file uploads #1362

merged 3 commits into from
May 13, 2021

Conversation

artandor
Copy link
Contributor

No description provided.

@artandor artandor changed the title Add documentation to test file uploads feat: Add documentation to test file uploads May 13, 2021
@artandor artandor changed the base branch from 2.6 to main May 13, 2021 16:32
@artandor artandor changed the base branch from main to 2.6 May 13, 2021 16:33
alanpoulain
alanpoulain reviewed May 13, 2021
View reviewed changes
alanpoulain
alanpoulain reviewed May 13, 2021
View reviewed changes
alanpoulain
alanpoulain reviewed May 13, 2021
View reviewed changes
alanpoulain
alanpoulain reviewed May 13, 2021
View reviewed changes
@alanpoulain
Copy link
Member

Hello, thanks for your PR, I've made minor comments but it looks good.

@artandor
Copy link
Contributor Author

Hello, thanks for your PR, I've made minor comments but it looks good.

Thanks ! I wasn't sure wether or not i should target main branch or current release. I got here by clicking the link at the bottom page of the documentation.

Should i remove the "parameters" array with custom fields ? It won't work out of the box with the code above, but on the other hand i struggled a bit to find that i shouldn't put this in body but in parameters instead.

alanpoulain
alanpoulain reviewed May 13, 2021
View reviewed changes
@alanpoulain
Copy link
Member

Targeting 2.6 is fine. You can leave the parameters, I think the comment is clear enough.

@alanpoulain alanpoulain merged commit d2a328b into api-platform:2.6 May 13, 2021
@alanpoulain
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanpoulain alanpoulain alanpoulain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artandor @alanpoulain