on|off is not supported in Boolean Filter anymore #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if master is the good branch or if it should target 2.0... |
teohhanhui
reviewed
Mar 2, 2017
core/filters.md
Outdated
| @@ -152,7 +152,7 @@ constant directly. | |||
|
|
|||
| The boolean filter allows you to search on boolean fields and values. | |||
|
|
|||
| Syntax: `?property=[on|off|true|false|0|1]` | |||
| Syntax: `?property=[true|false|0|1]` | |||
There was a problem hiding this comment.
true|false|1|0 to be consistent.
|
is there anything missing here that I can do/fix to get this documentation error fixed/merged ? |
soyuka
approved these changes
Mar 7, 2017
teohhanhui
approved these changes
Mar 7, 2017
|
Thanks @antograssiot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref api-platform/core#964