Add Exception configuration documentation #186
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review, ping @GregoireHebert |
GregoireHebert
suggested changes
Mar 20, 2017
|
|
||
| The framework also allows to configure the HTTP status code sent to the clients when custom exceptions are thrown. | ||
|
|
||
| In the following example, we will throw explain to throw a domain exception from the business layer of the application and |
There was a problem hiding this comment.
[...] we will throw explain to throw a domain exception [...]
| The framework also allows to configure the HTTP status code sent to the clients when custom exceptions are thrown. | ||
|
|
||
| In the following example, we will throw explain to throw a domain exception from the business layer of the application and | ||
| configure API Platform to convert it to a `404 Not Found` error. Let's create a this domain exception and the service throwing |
There was a problem hiding this comment.
[...] Let's create a this domain exception [...]
| } | ||
|
|
||
| if (!$product->isPubliclyAvailable()) { | ||
| // Using internal codes for a better understanding of what's going on |
There was a problem hiding this comment.
Finally there isn't internal code used here... Maybe remove the comment ?
|
This needs a rebase, @GregoireHebert could you please do it ? |
Merged
|
Oh sorry no, I can't, this is dunglas branch based on mine... I did it in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #173.