Skip to content

Update filters.md #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Update filters.md #1869

merged 1 commit into from
Jan 10, 2024

Conversation

fouteox
Copy link
Contributor

@fouteox fouteox commented Jan 9, 2024

abstract class AbstractFilter implements FilterInterface :

public function __construct(protected ManagerRegistry $managerRegistry, LoggerInterface $logger = null, protected ?array $properties = null, protected ?NameConverterInterface $nameConverter = null)
{
    $this->logger = $logger ?? new NullLogger();
}

The tild should not be in second position, it should be the log as shown in the AbstractFilter constructor

```php
abstract class AbstractFilter implements FilterInterface :

public function __construct(protected ManagerRegistry $managerRegistry, LoggerInterface $logger = null, protected ?array $properties = null, protected ?NameConverterInterface $nameConverter = null)
{
    $this->logger = $logger ?? new NullLogger();
}
```

The tild should not be in second position, it should be the log as shown in the AbstractFilter constructor
@soyuka soyuka merged commit 822fcca into api-platform:3.2 Jan 10, 2024
@soyuka
Copy link
Member

soyuka commented Jan 10, 2024

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants