refactor(doctrine): reference date filters constants from interface #2057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent interface Switched to using parent class constants directly in child classes for date-filtering strategies. Enhances code maintainability and consistency by centralizing constant values in the base interface (`DateFilterInterface`).
alanpoulain
approved these changes
Nov 8, 2024
soyuka
changed the title
vinceAmstoutz
deleted the
fix-doctrine-date-filter-interface-constants
branch
vinceAmstoutz
added a commit
to vinceAmstoutz/api-platform-docs
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors references to constants by switching from child to parent class references.
When child classes use constants defined in the base class (
\ApiPlatform\Doctrine\Common\Filter\DateFilterInterface), they inherit these constants directly from the parent. This approach enhances reusability and maintainability, ensuring that standardized values likeINCLUDE_NULL_BEFORE_AND_AFTERand other date-filtering constants are accessed directly from the source.This simplifies future modifications to constants and reduces the risk of inconsistencies across classes implementing or extending date-filtering behavior.
Phpstorm also warns it: