docs(pagination): support for laravel and reorganize #2070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinceAmstoutz
force-pushed
the
docs-pagination-support-laravel
branch
from
7da3774 to
f8fc604
Compare
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen with @dunglas, it's better to use
App\ApiResourceinstead ofApp\Entityto suit Symfony and Laravel.It avoids making the equivalence between models and entities in code examples (namespaces among others).
By the way, I've adapted the comments to be compatible with the 2 as well, so
// api/src/Entity/Book.phpbecomes// api/src/ApiResource/Book.php with Symfony or app/ApiResource/Book.php with Laravel.