Change confusing reference to removed service definition. #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Either the service definition should have stayed in the document or the line saying "First register the following service:" should have been removed. I went with the former.
|
Now see from api-platform/api-platform#84 that the service definition should have been dropped. Have removed and changed the confusing reference to the removed service definition. |
sh41
changed the title
teohhanhui
approved these changes
May 26, 2017
Simperfit
approved these changes
May 26, 2017
|
Thanks @sh41 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either the service definition should have stayed in the document or the line saying "First register the following service:" should have been removed. I went with the former. Was removed in c500601.