Proofread jwt #334
Merged
Proofread jwt #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is/should be? |
greg0ire
force-pushed
the
proofread_jwt
branch
from
02269f4 to
0670765
Compare
|
I'm not sure I get your question(s?)
No, far from it, there does not seem to be a limit at all.
If you want easier diffs, probably. |
greg0ire
force-pushed
the
proofread_jwt
branch
from
0670765 to
1f4ec32
Compare
github helps a lot with the word highlight though |
yes haha, and I thought we had a limit |
|
We have a limit, but we don't enforce it to not annoy the contributors... Maybe should we add a check for that and some guidance on how to fix it automatically. |
dunglas
reviewed
Nov 8, 2017
core/jwt.md
Outdated
|
|
||
|  | ||
|
|
||
| ### Adding a New API Key | ||
|
|
||
| All you have to do is to configure the API key in the value field. | ||
| By default [only the authorization header mode is enabled](https://github.com/lexik/LexikJWTAuthenticationBundle/blob/master/Resources/doc/index.md#2-use-the-token) in [LexikJWTAuthenticationBundle](https://github.com/lexik/LexikJWTAuthenticationBundle). | ||
| All you have to do is configure the API key in the `value` field. |
dunglas
approved these changes
Nov 8, 2017
soyuka
approved these changes
Nov 9, 2017
|
Thanks @greg0ire |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff would be easier to read if you capped lines to some limit (120 chars?). Consider it.