Skip to content

feature: add helm dependencies update #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Simperfit
Copy link
Contributor

No description provided.

@teohhanhui
Copy link
Contributor

teohhanhui commented May 4, 2018

https://docs.helm.sh/helm/#helm-dependency-update

On successful update, this will generate a lock file that can be used to rebuild the requirements to an exact version.

Shouldn't we check in the requirements.lock file? The command to use then becomes helm dependency build.

@teohhanhui
Copy link
Contributor

teohhanhui commented May 4, 2018

Actually we should also do helm repo update before that? (I'm not sure.)

@dunglas dunglas merged commit 0734d66 into api-platform:2.2 Jun 29, 2018
@dunglas
Copy link
Member

dunglas commented Jun 29, 2018

Thanks @Simperfit. I think we need to add the lock file, indeed.

@teohhanhui
Copy link
Contributor

@dunglas The requirements.lock file has been added in api-platform/api-platform#666

@dunglas
Copy link
Member

dunglas commented Jul 2, 2018

Do we need to update the docs then?

@teohhanhui
Copy link
Contributor

It depends on whether we think it's desirable to have fixed dependencies. I'm not sure it's the right thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants