Skip to content

Fixes #424 - Wrong Kernel Event / EventPriorities in Errors Example #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2018
Merged

Fixes #424 - Wrong Kernel Event / EventPriorities in Errors Example #508

merged 1 commit into from
Jun 20, 2018

Conversation

cvergne
Copy link
Contributor

@cvergne cvergne commented Jun 18, 2018

Hi,

So I made a new PR with the correct branch (2.2).

It fixes the example that doesn't work because the KernelEvents::REQUEST returns a GetResponseEvent instead of the required GetResponseForControllerResultEvent.
So as suggested in the issue #424 it's changed to the first hook available in KernelEvents::VIEW to get a GetResponseForControllerResultEvent : PRE_VALIDATE.

@cvergne cvergne mentioned this pull request Jun 18, 2018
Closed
@teohhanhui teohhanhui merged commit 2d3fab4 into api-platform:2.2 Jun 20, 2018
@teohhanhui
Copy link
Contributor

Thanks @cvergne. Nice catch! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cvergne @teohhanhui