Feat: Add validation groups on operations #516

toofff · 2018-06-27T21:55:48Z

No description provided.

alanpoulain · 2018-06-28T08:22:30Z

core/validation.md

@@ -167,6 +167,70 @@ Of course, you can use XML or YAML configuration format instead of annotations i
 You may also pass in a [group sequence](http://symfony.com/doc/current/validation/sequence_provider.html) in place of
 the array of group names.

+## Using Validation Groups on operations
+
+There are [5 types of operations](operations.md) in API Platform and you can have different validation for each.


validations?

I would reword There are [5 types of operations](operations.md). It's not exact: there are 2 builtin collection operations, and 4 item operations (PATCH is JSONAPI specific), but API Platform supports any type and any number of operations.

alanpoulain · 2018-06-28T08:23:40Z

core/validation.md

+/**
+ * @ApiResource(
+ *     collectionOperations={
+ *         "get"={"method"="GET"},


Maybe you can remove the explicit method declaration to be clearer?

ping @dunglas

When declaring the POST method, we have to declare the GET method to access it.

That's why I wanted to put it, because we often need the GET on the collection

No, I'm saying you can do like this:

* collectionOperations={ * "get", * "post"={"validation_groups"={"Default", "postValidation"}} * },

alanpoulain · 2018-06-28T08:25:18Z

core/validation.md

+
+`postValidation` contains the constraints on the name and author (length from 2 to 50) fields only.
+
+`putValidation` contains the constraints on the author (length from 2 to 70) fields only.


alanpoulain · 2018-06-28T08:28:51Z

core/validation.md

+
+With this configuration, there are three validation groups:
+
+`Default` contains the constraints in the current class and all referenced classes that belong to no other group.


I don't understand the all referenced classes part. You need a Valid assert for this kind of behavior, don't you?

alanpoulain · 2018-06-28T12:14:31Z

core/validation.md

@@ -167,6 +167,70 @@ Of course, you can use XML or YAML configuration format instead of annotations i
 You may also pass in a [group sequence](http://symfony.com/doc/current/validation/sequence_provider.html) in place of
 the array of group names.

+## Using Validation Groups on operations
+
+There are [2 builtin collection operations, and 4 item operations](operations.md) (PATCH is JSONAPI specific), but API Platform supports any type and any number of operations.


I would reword it like this:

You can have different validation for each [operation](operations.md) related to your resource.

Like this you don't need to duplicate the explanation about the concept of operations in API Platform.

alanpoulain · 2018-06-29T08:18:13Z

core/validation.md

+ * @ApiResource(
+ *     collectionOperations={
+ *         "get",
+ *         "post"={"method"="POST", "validation_groups"={"Default", "postValidation"}}


I think it's working if you remove the method part but I'm not sure about this.

dunglas · 2018-06-29T08:24:03Z

core/validation.md

+ *     itemOperations={
+ *         "delete",
+ *         "get",
+ *         "put"={"method"="PUT", "validation_groups"={"Default", "putValidation"}}


same here, you can remove "method"="PUT"

dunglas · 2018-06-29T08:24:13Z

core/validation.md

@@ -167,6 +167,70 @@ Of course, you can use XML or YAML configuration format instead of annotations i
 You may also pass in a [group sequence](http://symfony.com/doc/current/validation/sequence_provider.html) in place of
 the array of group names.

+## Using Validation Groups on operations


toofff · 2018-06-29T08:58:00Z

@dunglas @alanpoulain Done

dunglas · 2018-06-29T13:29:01Z

Thanks @toofff

alanpoulain reviewed Jun 28, 2018

View reviewed changes

alanpoulain reviewed Jun 29, 2018

View reviewed changes

dunglas approved these changes Jun 29, 2018

View reviewed changes

Feat: Add validation groups on operations

4999031

alanpoulain approved these changes Jun 29, 2018

View reviewed changes

dunglas merged commit 96c9cc5 into api-platform:2.2 Jun 29, 2018

toofff deleted the feature/update-validation-groups branch June 29, 2018 19:31


		`postValidation` contains the constraints on the name and author (length from 2 to 50) fields only.

		`putValidation` contains the constraints on the author (length from 2 to 70) fields only.


		With this configuration, there are three validation groups:

		`Default` contains the constraints in the current class and all referenced classes that belong to no other group.

Uh oh!

Feat: Add validation groups on operations #516

Feat: Add validation groups on operations #516

Uh oh!

Conversation

toofff commented Jun 27, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alanpoulain Jun 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

toofff commented Jun 29, 2018

Uh oh!

dunglas commented Jun 29, 2018

Uh oh!

Uh oh!

alanpoulain Jun 29, 2018 •

edited

Loading