Skip to content

Clarity, grammer, and style changes to serialization docs #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2018
Merged

Clarity, grammer, and style changes to serialization docs #539

merged 2 commits into from
Jul 16, 2018

Conversation

caseyamcl
Copy link
Contributor

I made some changes to the serialization documentation for clarity, grammar, and style. There were also a few typos that I corrected.

If you think this is a worthwhile PR, I would be happy to provide suggestions for some of the other pages in the documentation as well.

I made some changes to the serialization documentation for clarity, grammar, and style.  There were also a few typos that I corrected.

## Using Different Serialization Groups per Operation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This case is intended (title case)

@dunglas dunglas merged commit 875b701 into api-platform:2.3 Jul 16, 2018
@dunglas
Copy link
Member

dunglas commented Jul 16, 2018

Thank you, this kind of changes improve the quality of the documentation and are much appreciated!

I reverted some changes for consistency with other documentation entries:

It would be awesome if you can proof-read other documents!

@caseyamcl
Copy link
Contributor Author

@dunglas thanks! I appreciate being able to help with the project, and will continue to do so as time allows.

@@ -8,12 +8,12 @@ The main serialization process has two stages:

![Serializer workflow](images/SerializerWorkflow.png)

> As you can see in the picture above, an array is used as a man in the middle. This way, Encoders will only deal with turning specific formats into arrays and vice versa. The same way, Normalizers will deal with turning specific objects into arrays and vice versa.
> As you can see in the picture above, an array is used as a man-in-the-middle. This way, Encoders will only deal with turning specific formats into arrays and vice versa. The same way, Normalizers will deal with turning specific objects into arrays and vice versa.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MITM might be understood as an attack lol... Maybe we could say "an intermediary".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teohhanhui I agree, although I didn't change that, because I thought it was a direct quote from the Symfony Docs. Looking at the docs, now I see they have updated the language over there.

-- [The Symfony documentation](https://symfony.com/doc/current/components/serializer.html)

Unlike Symfony itself, API Platform leverages custom normalizers, its router and the [data provider](data-providers.md) system to do an advanced transformation. Metadata are added to the generated document including links, type information, pagination data or available filters.

The API Platform Serializer is extendable, you can register custom normalizers and encoders to support other formats. You can also decorate existing normalizers to customize their behaviors.
The API Platform Serializer is extendable. You can register custom normalizers and encoders in order to support other formats. You can also decorate existing normalizers to customize their behaviors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the context of PHP, "extendable" might give the wrong idea of the class being able to be extended, so perhaps we could use the synonym "extensible".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teohhanhui Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants