#461 - Add access control example #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
reviewed
Oct 8, 2018
alanpoulain
reviewed
Oct 8, 2018
core/operations.md
Outdated
| @@ -462,6 +462,21 @@ class Question | |||
| } | |||
| ``` | |||
|
|
|||
| ### Access Control of Subresources | |||
|
|
|||
| The `subresourceOperations` annotation also allows you to add an access control on each path with the directive `access_control `. | |||
There was a problem hiding this comment.
I think you can use "attribute" instead of "annotation" and "directive".
alanpoulain
reviewed
Oct 8, 2018
|
One last thing, this PR should target 2.3 IMO (please rebase your branch beforehand). |
Update doc for access control after comment Update doc for access control after comment 2 Update doc for access control add reference Question on xample Update doc for access control add reference Question on xample
|
@alanpoulain it's rebase |
alanpoulain
approved these changes
Oct 8, 2018
alanpoulain
reviewed
Oct 8, 2018
core/operations.md
Outdated
| @@ -462,6 +462,29 @@ class Question | |||
| } | |||
| ``` | |||
|
|
|||
| ### Access Control of Subresources | |||
|
|
|||
| The `subresourceOperations` attribute also allows you to add an access control on each path with the attribute `access_control `. | |||
There was a problem hiding this comment.
Minor comment: you can remove the space in "access_control ".
|
Thanks @tim59 ! |
|
You're welcome 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for adding the access control on path annotation.
refer to #461