Skip to content

Fix typo bookService by bookRepository #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2018

Conversation

maxhelias
Copy link
Contributor

No description provided.

@@ -416,17 +416,17 @@ The Controller would look like this:
namespace App\Controller\Book;

use ApiPlatform\Core\Bridge\Doctrine\Orm\Paginator;
use App\Service\Book\BookService;
use App\Repository\BookRepository;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The service doesn't need to be a repository right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but in the examples on the page it's a repository

@dunglas dunglas merged commit da18285 into api-platform:2.3 Nov 6, 2018
@dunglas
Copy link
Member

dunglas commented Nov 6, 2018

Good catch, thanks @maxhelias!

@maxhelias maxhelias deleted the patch-1 branch December 30, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants