Skip to content

[ADMIN] Add missing code in example #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2019
Merged

[ADMIN] Add missing code in example #695

merged 1 commit into from
Jan 6, 2019

Conversation

mnlkrs
Copy link
Contributor

@mnlkrs mnlkrs commented Jan 2, 2019

Must've been forgotten:

  • import { RichTextField } from 'react-admin'; is imported but never actually used
  • "The field property of the Field class allows to set the component used to render a property in list and show screens." - however, the field property is never set

Code was validated to work.

@alanpoulain alanpoulain merged commit fd22f7d into api-platform:2.3 Jan 6, 2019
@alanpoulain
Copy link
Member

Thank you @mnlkrs

@mnlkrs mnlkrs deleted the fix/admin_example branch January 6, 2019 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants