Fix error in filters documentation #696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
reviewed
Jan 6, 2019
core/filters.md
Outdated
| @@ -324,7 +324,7 @@ class Offer | |||
| } | |||
| ``` | |||
|
|
|||
| Given that the collection endpoint is `/offers`, you can filter offers by boolean with the following query: `/offers?sold=1`. | |||
| Given that the collection endpoint is `/offers`, you can filter offers by numeric with the following query: `/offers?sold=1`. | |||
There was a problem hiding this comment.
IMO "by numeric" is not very clear. I'm suggesting to remove it instead.
There was a problem hiding this comment.
And do the same for the boolean filter. Or find another sentences.
There was a problem hiding this comment.
Hello @alanpoulain,
It's done, thank you for your feedback.
alanpoulain
approved these changes
Jan 6, 2019
maxhelias
approved these changes
Jan 6, 2019
|
Thanks @alegout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error in https://api-platform.com/docs/core/filters#numeric-filter (text is same as boolean filters)