Skip to content

Correct the project directory from api to bookshop-api the example project #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 8, 2019

Conversation

ssmusoke
Copy link
Contributor

This is to make it consistent with the project name created with the first command

This is to make it consistent with the project name created with the first command
Copy link
Member

@alanpoulain alanpoulain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to link to the documentation for installing the distribution instead of using composer create-project api-platform/api-platform.

@ssmusoke
Copy link
Contributor Author

ssmusoke commented Mar 11, 2019

While it may be better to link to the install documentation, putting the commands here helps the flow for the example rather than having to go somewhere first to get started.

Maybe add a link to the install documentation, while maintaining the commands here too

@alanpoulain
Copy link
Member

I think you misunderstood. We don't really support this command anymore.
And IMO it would be better to have a link, because the install documentation explains the possibilities and how it works.

@ssmusoke ssmusoke changed the title Correct the project directory from api to api-platform Correct the project directory from api to bookshop-api the example project Mar 13, 2019
@ssmusoke
Copy link
Contributor Author

Updated to use the example project name to match the setup instructions

@dunglas dunglas merged commit 6538e56 into api-platform:2.4 Jun 8, 2019
@dunglas
Copy link
Member

dunglas commented Jun 8, 2019

Thanks @ssmusoke!

@ssmusoke ssmusoke deleted the patch-1 branch June 8, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants