Skip to content

Prevent uploaded files from being overwritten #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2019
Merged

Prevent uploaded files from being overwritten #981

merged 2 commits into from
Nov 8, 2019

Conversation

jaapjan
Copy link
Contributor

@jaapjan jaapjan commented Nov 7, 2019

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tickets -
License MIT
Doc PR api-platform/docs#...

When someone uploads a file with an already existing name it overwrites the existing file. Easily prevented by providing this configuration.

When someone uploads a file with an already existing name it overwrites the existing file. Easily prevented by providing this configuration.
@@ -26,6 +26,7 @@ vich_uploader:
media_object:
uri_prefix: /media
upload_destination: '%kernel.project_dir%/public/media'
namer: Vich\UploaderBundle\Naming\OrignameNamer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment on top of that explaining what it does?

Copy link
Contributor Author

@jaapjan jaapjan Nov 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Done ✅ 556fe43
Please let me know if it's ok like this.

@soyuka soyuka merged commit 63a2fc8 into api-platform:2.5 Nov 8, 2019
@soyuka
Copy link
Member

soyuka commented Nov 8, 2019

thanks @jaapjan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants