Catch up to JS client #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
t-core-services
…y-client-python into feature/catch-up-to-js-client
fnesveda
requested changes
Nov 30, 2022
fnesveda
requested changes
Nov 30, 2022
fnesveda
requested changes
Dec 1, 2022
Co-authored-by: František Nesveda <[email protected]>
yes, i'm struggling with snake case a lot atm :D |
fnesveda
approved these changes
Dec 2, 2022
fnesveda
added
the
validated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only thing omitted is the
titleparameter for dataset, kvs and rq, I only added it for schedule and task. This is because it would be inconsistent in the current state i.e. you cannot create a storage with atitlebut you can do it via update. See apify/apify-client-js#271Should be merged after the logger PR #86 since I merged it into this branch.