Skip to content

Fix contribution guidelines link in PR templates #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

iSame7
Copy link
Contributor

@iSame7 iSame7 commented Oct 10, 2020

This PR fix the path for contribution guidelines in PR templates.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@natecook1000
Copy link
Member

Thanks, @iSame7!

@natecook1000 natecook1000 merged commit 546c8bf into apple:main Oct 12, 2020
@mdznr
Copy link
Contributor

mdznr commented Feb 10, 2021

The relative references are correct with respect to a local filesystem, but don’t work when viewing a pull request on github.com.

If you're on a page like #16 and click on a link to ../CONTRIBUTING.md, it goes to https://github.com/apple/swift-algorithms/CONTRIBUTING.md which gives a 404. The correct link would be https://github.com/apple/swift-algorithms/blob/main/CONTRIBUTING.md

@LemonSpike
Copy link
Contributor

LemonSpike commented Apr 17, 2021

@mdznr I don't think we need to keep the link correct for the file viewer, correct? This relates to #134.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants